Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

fix: FLOW-944 z-index issue with target , overlay and popover #159

Merged
merged 4 commits into from
Oct 17, 2023
Merged

fix: FLOW-944 z-index issue with target , overlay and popover #159

merged 4 commits into from
Oct 17, 2023

Conversation

vikas-cldcvr
Copy link
Contributor

@vikas-cldcvr vikas-cldcvr commented Oct 13, 2023 •
edited
Loading

Checklist for raising a PR

  • Gone through UX documnetation for adding new features.
  • All necessary unit tests covered.
  • Required comments added for generating component manifest file? you can find details here
  • Did you check the contributing doc?
  • Did you check the existing issues for similar queries?

Describe your PR

This issue gets replicated when we have a dropdown at the bottom of the popover and the popover is positioned at the top of the target
image (36)

[2.1.1] - 2023-10-17

Bug Fixes

  • f-popover: z-index issue with target , overlay and popover fixed.

Add additional question here

  • Yes
  • No
  • NA

@vikas-cldcvr vikas-cldcvr added the bug Something isn't working label Oct 16, 2023
@datapipes-robot

This comment was marked as resolved.

Sign in to view
@vikas-cldcvr vikas-cldcvr changed the title FLOW-944 z-index issue with target , overlay and popover fix: FLOW-944 z-index issue with target , overlay and popover Oct 17, 2023
@vikas-cldcvr vikas-cldcvr marked this pull request as ready for review October 17, 2023 11:55
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@datapipes-robot datapipes-robot bot added the lgtm label Oct 17, 2023
@vikas-cldcvr vikas-cldcvr merged commit 915006a into main Oct 17, 2023
5 of 6 checks passed
@vikas-cldcvr vikas-cldcvr deleted the vikas/FLOW-944 branch October 17, 2023 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NikhilVerma NikhilVerma NikhilVerma approved these changes

@mayankfulera mayankfulera Awaiting requested review from mayankfulera

Assignees

@NikhilVerma NikhilVerma

Labels
bug Something isn't working do-not-merge/invalid-pr-title lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikas-cldcvr @NikhilVerma