Skip to content

Commit

Permalink
modifications suggessed by Lasse. But it does not work. I get: fontba…
Browse files Browse the repository at this point in the history
…kery.errors.SetupError: Profile fails expected checks test:

unexpected checks: com.google.fonts/check/family/italics_have_roman_counterparts, com.google.fonts/check/fstype, com.google.fonts/check/gasp, com.google.fonts/check/canonical_filename, com.google.fonts/check/vendor_id;
  • Loading branch information
ollimeier committed Feb 1, 2022
1 parent b142942 commit 594e79c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Lib/fontbakery/profiles/fontwerk.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@
'com.google.fonts/check/canonical_filename',
'com.google.fonts/check/vendor_id',
'com.google.fonts/check/family/italics_have_roman_counterparts',
'com.google.fonts/check/fstype',
'com.google.fonts/check/gasp',
]

FONTWERK_PROFILE_CHECKS = \
GOOGLEFONTS_PROFILE_CHECKS + [
[check for check in GOOGLEFONTS_PROFILE_CHECKS
if check not in CHECKS_DONT_DO] + [
'com.fontwerk/check/no_mac_entries',
'com.fontwerk/check/vendor_id',
'com.fontwerk/check/weight_class_fvar',
Expand Down Expand Up @@ -99,7 +102,5 @@ def com_fontwerk_check_weight_class_fvar(ttFont):
else:
yield PASS, f"OS/2 usWeightClass '{os2_value}' matches fvar default value."

# profile.auto_register(globals(), filter_func=lambda type, id: not (type == 'check' and id in CHECKS_DONT_DO))
# still no idea how to remove checks
profile.auto_register(globals())
profile.test_expected_checks(FONTWERK_PROFILE_CHECKS, exclusive=True)

0 comments on commit 594e79c

Please sign in to comment.