Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Update rebuses.js #219

Closed
wants to merge 1 commit into from
Closed

Conversation

ljaym310
Copy link

@ljaym310 ljaym310 commented Mar 1, 2019

Associated Issue: #121

Summary of Changes

  • added rebus
  • first commit!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 456

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.617%

Totals Coverage Status
Change from base Build 455: 0.0%
Covered Lines: 154
Relevant Lines: 175

💛 - Coveralls

Copy link
Owner

@ollelauribostrom ollelauribostrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a few comments that needs to be fixed before I can merge this.

@@ -9,6 +9,11 @@ const rebuses = [
words: ['Houseplants'],
hint: `The second emoji is 'ant' not 'bug'`
},
{
symbols: ['(after ❌)', '+(🐝-b)','+☕️'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space before the last item in the array to make the linter happy. Also, could you move this down to the end of the array? 🙂

@ljaym310 ljaym310 closed this Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants