Skip to content

Commit

Permalink
Upgrade (1.28.0 -> 1.28.1) and drop NET_BIND_SERVICE workaround
Browse files Browse the repository at this point in the history
  • Loading branch information
spantaleev authored and Oliver Lorenz committed Jun 21, 2024
1 parent 399bd2d commit 0637a2a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ vaultwarden_enabled: true

vaultwarden_identifier: vaultwarden

vaultwarden_version: 1.28.0
vaultwarden_version: 1.28.1

# The fully-qualified name of your Vaultwarden server (e.g. `vaultwarden.example.com`)
vaultwarden_hostname: ''
Expand Down
5 changes: 0 additions & 5 deletions templates/vaultwarden.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,13 @@ ExecStartPre=-{{ devture_systemd_docker_base_host_command_sh }} -c '{{ devture_s
- the recheck interval is too long (60s) and the service is considered `starting`
- when a service is not `healthy`, Traefik does not reverse-proxy to it -- leading to 1 minute downtime every single time this restarts
#}
{#
NET_BIND_SERVICE became necessary after the (v1.27.0 -> v1.28.0) upgrade.
See: https://github.com/dani-garcia/vaultwarden/issues/3386
#}
ExecStartPre={{ devture_systemd_docker_base_host_command_docker }} create \
--rm \
--name={{ vaultwarden_identifier }} \
--log-driver=none \
--network={{ vaultwarden_container_network }} \
--user={{ vaultwarden_uid }}:{{ vaultwarden_gid }} \
--cap-drop=ALL \
--cap-add=NET_BIND_SERVICE \
--read-only \
--hostname={{ vaultwarden_hostname }} \
{% if vaultwarden_container_http_bind_port %}
Expand Down

0 comments on commit 0637a2a

Please sign in to comment.