fix: revert c7e78f5

oliverbooth · Nov 14, 2024 · 44d3aec · 44d3aec
1 parent 0be10d8
commit 44d3aec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,8 +9,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-- X1OD: `IBinaryInteger<T>.Factorial` now starts at `IBinaryInteger<T>.MultiplicativeIdentity` not
-`IBinaryInteger<T>.One`.
 - X10D: Removed `IEnumerable<T>.GreatestCommonFactor` for all integer types in favour of generic math.
 - X10D: Removed `IEnumerable<T>.LowestCommonMultiple` for all integer types in favour of generic math.
 - X10D: Removed `IEnumerable<T>.Product` for all integer types in favour of generic math.

diff --git a/X10D/src/Math/BinaryIntegerExtensions.cs b/X10D/src/Math/BinaryIntegerExtensions.cs
@@ -69,12 +69,12 @@ public static long Factorial<TInteger>(this TInteger value)
             return 1;
         }
 
-        TInteger result = TInteger.MultiplicativeIdentity;
+        long result = 1L;
         for (TInteger i = TInteger.One; i <= value; i++)
         {
-            result *= i;
+            result *= long.CreateChecked(i);
         }
 
-        return long.CreateChecked(result);
+        return result;
     }
 }