Fix incorrectly calculated height on collapes rows #4425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Oli,
as mentioned in the issue #3654 ( So i'm going to copy and paste a bit 😜 )
I noticed in the VirtualDomVertical module in _removeTopRow the row height is always the same even though the rows are not the same height.
I think the issue is the column height isn't recalculated after the rows are collapsed, so I've added a call to
calcHeight()
after the rows are collapsed.Cheers,
Antonio