Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Copy for Edition #204

Merged
merged 1 commit into from
Mar 31, 2023
Merged

impl Copy for Edition #204

merged 1 commit into from
Mar 31, 2023

Conversation

msrd0
Copy link
Contributor

@msrd0 msrd0 commented Sep 9, 2022

No description provided.

jplatte
jplatte reviewed Sep 10, 2022
View reviewed changes
Copy link

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessarily a good idea. It makes extra promises that aren't really that important, and would have to be removed again if Edition was changed to allow arbitrary edition strings (which would not necessarily be a breaking change).

@msrd0
Copy link
Contributor Author

msrd0 commented Sep 10, 2022

If we can make the assumption that editions will continue to be named after the year they are introduced in, this shouldn't be a problem.

@oli-obk
Copy link
Owner

oli-obk commented Sep 13, 2022

I'm fine making it Copy, if we switch to a more stringly typed representation we are likely at a stage where a new major bump is a good idea anyway.

@oli-obk oli-obk merged commit b489620 into oli-obk:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msrd0 @oli-obk @jplatte