Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cucumber data table #56
Cucumber data table #56
Changes from 4 commits
960a114
f856086
301b9fb
a99c8db
943f4bd
727e301
68361cd
025913e
7ec8961
38efd4e
297c363
4515e66
4997c6c
7da6de1
5c60cc9
811ac72
8b42acb
d62d966
940071b
4f37df6
045899c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types for all other lines from features files are described in
LineType
enum. Are there any reason why the data table line can not follow the same pattern?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides _lineTypeFromString which needs the next lines in order to determine the dataTable type, the
step enum is used in the generation logic which fails the tests when I add the new type.
It also adds a lot of boilerplate (will have to be repeated in multiple places):
LineType enum describes unique lines that can be map to those types.
A cucumber data table is determined by the combination of a step and examples.
I'll be happy to explore any proposal that might simplify and keep the existing convention though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new enum value dataTableStep and modified the StepFile.create to accept the domain model BDD line instead of its internal implementation details.