Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: For steps with example have column names for parameters #48

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat: For steps with example have column names for parameters #48

merged 2 commits into from
Dec 4, 2023

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Nov 29, 2023

  • All tests passed

Add the possibility of having the name of the column rather than param1 in the case of a step with examples.

Is it possible that in <> there are only numbers (like <12.3>)?

Feature: Testing feature
  Scenario: eating
    Given there are <number> cucumbers

    Examples:
      | number |
      |   12   |
      |   20   |

Before:

import 'package:flutter_test/flutter_test.dart';

Future<void> thereAreCucumbers(WidgetTester tester, dynamic param1) async {
  throw UnimplementedError();
}

After:

import 'package:flutter_test/flutter_test.dart';

Future<void> thereAreCucumbers(WidgetTester tester, dynamic number) async {
  throw UnimplementedError();
}

@olexale
Copy link
Owner

olexale commented Dec 1, 2023

Thanks for the PR! I'll review it on the weekend.

Copy link
Owner

@olexale olexale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice small UX improvement that many of the users will notice! Thank you so much for it. I'm happy to merge the PR and publish a new version as soon as we are done with comments.

lib/src/step/generic_step.dart Outdated Show resolved Hide resolved
test/steps_test.dart Outdated Show resolved Hide resolved
@olexale olexale merged commit e88cd05 into olexale:master Dec 4, 2023
1 check passed
@olexale
Copy link
Owner

olexale commented Dec 4, 2023

Thanks again, @lsaudon! I'll publish a new version of the package with your changes soon.

@lsaudon
Copy link
Contributor Author

lsaudon commented Dec 4, 2023

Thanks again, @lsaudon! I'll publish a new version of the package with your changes soon.

Thank you for this package and your responsiveness.

@lsaudon lsaudon deleted the steps-with-examples-column-names-for-param branch December 7, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants