#123 & #124 Feature/askpassphrase #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* context.go - added global variable gAskPassphrase and added PromptForPassword() to get passphrase * cmd/trousseau/before.go - updateCheckPassphrase() to update global variable * cmd/trousseau/main.go - added Blooflag struct to give comments in help
* gPassphrase in context.go * helpers in context.go * calling AskPassphrase from before.go sets gPassphrase
|
Super good! Matches exactly what I was thinking (ref #123) ! Have tested it locally and it works as expected. I'm gonna merge it now. I've noticed two things though:
which in this case is not precise enough, and might be confusing for the user trying to understand why it's not working and actually being pointed to a wrong problem description. I've created another ticket for this: #130 Thank you very much for this addition and the work done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Issue #123 and closes #124 (request to merge into wrong branch)