clip #1
Open
clip #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a flexbox we can easily center the checkmark without using hard coded positions.
Using <length> type values for line-height can give unexpected inheritance behaviors. If using <length> values, the inherited line-height on children is calculated using the font-size of the parent. What we want is for the line-height of children to be calculated using it's own font-size. By instead using a unitless number, we get the behavior we want. Note that this bug has no effects right now since no children to any of the related elements have different font-sizes.
…d-langs Add english to list of supported languages
We expect the promise to be rejected with a string for display to the user.
Allows easier testing by being able to run the test multiple times.
We should not be listing this in LINGUAS as that gives the impression that English has en explicit translation. Instead, it is a special case that the code needs to be explicitly aware of. This reverts 9a06058 in favour of a more robust fix.
We want tests to be independent, so we cannot have them modify a shared state, such as the l10n singleton. Make sure each test instantiates its own object instead.
This is a revert of the code changes in commit f796b05 as it served no functional purpose. Fragments were already respected for setting parameters, via a different function. Thus it is unclear what that commit tried to fix. It also complicated things by mixing the document location with the window location. The comment changes are useful, though, so those are kept.
We don't want to mess up anything permanent in each test or the tests might start affecting each other.
Let's try to keep as much as possible of the translation handling in a single place for clarity.
This test didn't really check anything useful as the end result would be the same if the second JPEG failed to render. Fix this by clearing the canvas between the images, so we can tell if the second image actually rendered or not.
Let them all follow the same pattern to make things more clear.
The event handlers might provide the needed response right away, before even existing the event handler. We should be prepared to handle this case.
This matches the true contents of a WebSocket 'message' event, so should be a more realistic test.
The given data was not a correct RRE rect.
The "None" authentication will directly progress past authentication, so it's not a good type for this test.
Spies should just attach without modifying the real method, or we might get unwanted side effects.
This is not something we intend to implement, so remove this never used test case.
We should test using only external manipulation so we don't assume a specific implementation.
Avoid poking around in the internals and instead test things using the official methods and events. This should give us more realistic and robust tests.
VeNCrypt is a multiplexer for many authentication methods, not just Plain. So let's split it to its own section, just like other types.
We should have constants local for the test function when doing comparisons or we might have false positives because we compare with buggy values in the code under test.
karma-sinon-chai is not compatible with Chai 5+, and Karma is no longer being updated. Load sinon and chai manually instead, until we can have a long term plan in place.
Likely a lot safer for corner cases than us trying to figure this out ourselves.
This can be very useful if you have multiple instances of noVNC, and you want to redirect them to different VNC servers. The new default settings will have the same behaviour as before for systems where noVNC is deployed in the root web folder.
Makes sure everything behaves the same way, even if there is no visible UI for a settings.
Makes it easier to see how things are connected.
This adds an H.264 decoder based on WebCodecs.
We need to call initSetting() even if we don't have any interesting default to set, as that is what checks if values have been provided as a query string. Fixes 96c76f7.
Dynamically grow the recorded send buffer if the test needs to send a lot of data.
These failed to test that the data was correctly split as they only checked the first chunk transmitted. Use random values to avoid the risk of aligning our test data with the split boundaries and hence allowing false positives.
Expose a simple and stable API to override default settings, and force settings that users shouldn't be able to change.
Make it even easier to customize things by loading the settings from separate configuration files.
It returns an object with details, not just a simple boolean.
Avoid duplicating this logic in multiple places.
So that we can use await at module top level.
Firefox is buggy and reports support for H.264 but then throws errors once we actually try to decode things. Detect this early by doing a quick test decode of a single frame.
These are not supposed to happen according to the specification, but Firefox has some bug and throws them anyway.
The Firefox H.264 decoder on Windows might simply just refuse to deliver any finished frames. It also doesn't deliver any errors. Detect this early by expecting a frame after flush() has completed.
Try to be more consistent in how we capitalize things. Both the "Title Case" and "Sentence case" styles are popular, so either would work. Google and Mozilla both prefer "Sentence case", so let's follow them.
This would have resolved itself automatically on the next translation update, but this commit will reduce unnecessary noise in that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.