-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide official sbt launch script as default #43
provide official sbt launch script as default #43
Conversation
also continue providing sbt-extras, but as `sbtx`
I haven't tested this, but the change seems pretty straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you! I’ll cut a new release later today.
Hello guys, may I ask what is the motivation for this change? 🙂 |
@sideeffffect I think this PR fixes the issues here #35 |
@sideeffffect see sbt/sbt#2889, where I have just left some fresh commentary (since this is bigger than just setup-scala) |
as for setup-scala specifically, I just noticed at https://github.com/olafurpg/setup-scala/releases/tag/v13 that it says:
that surprises me a bit, actually. I personally don't mind, but perhaps someone else will want to make a pitch for retaining the alternates? |
@SethTisue I’m not using those scripts and I don’t think other people are using them either. It would be nice to avoid installing those scripts. |
also continue providing sbt-extras, but as
sbtx
Olaf has already indicated (on Discord, I think it was?) that this change would be welcome