Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): use local static files for js-sequence-diagrams,flowch… #76

Closed
wants to merge 1 commit into from

Conversation

morya
Copy link
Contributor

@morya morya commented Jun 27, 2018

…art,mathjax so this theme could be used inside intranet

PR to fix #63 .

…art,mathjax so this theme could be used inside intranet
@olOwOlo
Copy link
Owner

olOwOlo commented Jun 27, 2018

谢谢你的 PR!

有两个问题:

  • 不要直接移除 CDN,把它们添加到 params.publicCDN,请参考那些实现
  • 我不怎么用 mathjax,但是据我目前所知,把 mathjax 本地化是需要克隆整个 repo 的(我会给它额外添加一个参数的,麻烦还原一下

我发现这个修改有点小小的 BREAKING CHANGE 的意思,如果你修改好了的话,我会留到 4.0.0 版本再合并 😄。

@olOwOlo olOwOlo added this to the 4.0.0 milestone Jun 27, 2018
@morya
Copy link
Contributor Author

morya commented Jun 28, 2018

哈,改mathjax有点冲动,等我再提一个

@olOwOlo olOwOlo closed this in cec9ea9 Nov 6, 2018
daymade pushed a commit to daymade/hugo-theme-even that referenced this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants