Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open EIP2028 when Istanbul version enabled #579

Merged
merged 1 commit into from
Jan 22, 2021
Merged

open EIP2028 when Istanbul version enabled #579

merged 1 commit into from
Jan 22, 2021

Conversation

KamiD
Copy link
Member

@KamiD KamiD commented Jan 22, 2021

Closes :cosmos/ethermint#730

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #579 (d6b635c) into dev (4a06840) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #579      +/-   ##
==========================================
- Coverage   66.65%   66.62%   -0.03%     
==========================================
  Files         306      306              
  Lines       19009    19011       +2     
==========================================
- Hits        12670    12666       -4     
- Misses       5623     5629       +6     
  Partials      716      716              
Impacted Files Coverage Δ
x/evm/types/chain_config.go 100.00% <100.00%> (ø)
x/evm/types/state_transition.go 93.16% <100.00%> (ø)
x/backend/keeper/keeper_channel.go 45.16% <0.00%> (-4.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a06840...d6b635c. Read the comment docs.

@KamiD KamiD merged commit 0f1e41c into dev Jan 22, 2021
@zhongqiuwood zhongqiuwood deleted the fix-open-eip2028 branch February 8, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants