ul blog improvements #1522
Merged
ul blog improvements #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for okta-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
edunham
approved these changes
Aug 19, 2024
alisaduncan
reviewed
Aug 19, 2024
| // Redirect user back to the sign in page | ||
| window.location.href = '/'; | ||
| // Redirect user back to the sign in page | ||
| window.location.href = '/'; |
There was a problem hiding this comment.
out of curiosity, why are using window API here to redirect to home. I thought this is handled already inside the todo app, can't we use React Router?
There was a problem hiding this comment.
will pick up on this in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blog post has the following features: