Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post for updates in Okta Angular SDK #1337

Merged
merged 6 commits into from
Mar 7, 2023

Conversation

alisaduncan
Copy link
Member

This blog post has the following features:

  • A title that's approved by Dev Advocacy
  • A URL that's approved by Dev Advocacy
  • The content has been run through Grammarly (https://www.grammarly.com/)
  • Rendered locally and confirmed that no Markdown typos exist

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for okta-blog ready!

Name Link
🔨 Latest commit c183c40
🔍 Latest deploy log https://app.netlify.com/sites/okta-blog/deploys/64063dbf5c4f6b0008ba4a9f
😎 Deploy Preview https://deploy-preview-1337--okta-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@edunham edunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short, sweet, and to the point -- beautiful!

Copy link
Member

@edunham edunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrating editorial changes to show Colton the github review process :)

_source/_posts/2023-02-20-angular-forroot.md Outdated Show resolved Hide resolved
export class AppModule { }
```

This method will continue to work, and you can continue using the module as you have it now without any changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This method will continue to work, and you can continue using the module as you have it now without any changes.
This method will continue to work, and you can keep on using the module as you have it now without any changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edunham maybe a fine line, but I'd like to keep it as continue. Trying to encourage the pattern going forward should change, and keep on sounds more positive than continue to me?

@alisaduncan alisaduncan merged commit a003c58 into oktadev:main Mar 7, 2023
@alisaduncan alisaduncan deleted the angular-forroot branch March 7, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants