Specify kid when provided for JWT #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| headers = {} | ||
|
|
||
| # # Check if kid was supplied | ||
| if kid: |
There was a problem hiding this comment.
Check if kid was provided in client config
if not, check in private key
justinabrokwah-okta
force-pushed
the
jabro-okta-525317-specify-kid-for-jwt
branch
from
ed45f4e to
65f6e7d
Compare
Comment on lines
+27
to
+30
| # check if kid is provided in config - set if so | ||
| kid = self._config["client"]["kid"] if "kid" in self._config["client"] else None | ||
|
|
||
| return JWT.create_token(org_url, client_id, private_key) | ||
| return JWT.create_token(org_url, client_id, private_key, kid) |
There was a problem hiding this comment.
Checking for a key id in the config and using it if provided
bryanapellanes-okta
deleted the
jabro-okta-525317-specify-kid-for-jwt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for JWT to be encoded with kid in headers when provided by user
Addressing #289