Support customized HTTP Request Headers #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix problem where sometimes headers weren't being overwritten correctly - Add test to verify
Comment on lines
+121
to
+122
| headers = {**self._custom_headers, **headers} | ||
| headers = {**self._default_headers, **headers} |
There was a problem hiding this comment.
The **syntax destructures the dictionaries and prioritizes entries in the headers parameter set by the user
Comment on lines
+117
to
+123
| @pytest.mark.parametrize( | ||
| "accept_header", | ||
| ["", "application/xml", "application/json", | ||
| "text/html", "application/xhtml+xml", "image/jpeg"] | ||
| ) | ||
| @pytest.mark.asyncio | ||
| async def test_overwrite_default_request_executor_headers(accept_header): |
There was a problem hiding this comment.
Parametrized test added to test out various Accept headers
arvindkrishnakumar-okta
approved these changes
Feb 1, 2023
bryanapellanes-okta
deleted the
jabro-okta-525379-fix-request-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OKTA-525379:
Acceptheader which defaults toapplication/json