Update to model generation for MultiValueEnum's #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially OAuthGrantType in question
Comment on lines
-42
to
-43
| self.pkce_required = config["pkceRequired"]\ | ||
| if "pkceRequired" in config else None |
There was a problem hiding this comment.
Removals in this file were done when running yarn build against the spec
Comment on lines
+37
to
+40
| SAML_2_BEARER = "urn:ietf:params:oauth:grant-type:saml2-bearer", "URN:IETF:PARAMS:OAUTH:GRANT-TYPE:SAML2-BEARER" | ||
| DEVICE_CODE = "urn:ietf:params:oauth:grant-type:device_code", "URN:IETF:PARAMS:OAUTH:GRANT-TYPE:DEVICE_CODE" | ||
| TOKEN_EXCHANGE = "urn:ietf:params:oauth:grant-type:token-exchange", "URN:IETF:PARAMS:OAUTH:GRANT-TYPE:TOKEN-EXCHANGE" | ||
| INTERACTION_CODE = "interaction_code", "INTERACTION_CODE" |
There was a problem hiding this comment.
Newly added OAuthGrantTypes
| @@ -31,4 +31,3 @@ class OpenIdConnectApplicationIssuerMode( | |||
|
|
|||
| CUSTOM_URL = "CUSTOM_URL", "custom_url" | |||
| ORG_URL = "ORG_URL", "org_url" | |||
| DYNAMIC = "DYNAMIC", "dynamic" | |||
There was a problem hiding this comment.
Removed during yarn build
Comment on lines
+480
to
+496
| const URN_GRANT_TYPES = ['device_code', 'saml2_bearer', 'token_exchange']; | ||
| const URN_PREFIX = 'urn:ietf:params:oauth:grant-type:'; | ||
| const URN_SUFFIXES = { | ||
| 'device_code': 'device_code', | ||
| 'saml2_bearer': 'saml2-bearer', | ||
| 'token_exchange': 'token-exchange' | ||
| }; | ||
|
|
||
| // Determines if OAuthGrantType needs prefix | ||
| function isUrnGrantType(grantType) { | ||
| return URN_GRANT_TYPES.includes(grantType); | ||
| } | ||
|
|
||
| // Prefixes openAPI spec enum with OAuthGrantType urn prefix | ||
| function prefixUrnGrantType(grantType) { | ||
| return URN_PREFIX + URN_SUFFIXES[grantType]; | ||
| } |
There was a problem hiding this comment.
Helper functions used to determine if a grant type needs the urn prefix (urn:ietf:params:oauth:grant-type:) and if so, to prefix it onto the actual enum value
| version "2.11.1" | ||
| resolved "https://registry.yarnpkg.com/@okta/openapi/-/openapi-2.11.1.tgz#49e9738fbd68520b7a2deaf74d63f67e41a3e924" | ||
| integrity sha512-FdDTwscwULg94nGFAhlncLpKr+46nfkjWe2npe9+Th8xaMcnRYtymsUMI8wXNMrOxOJ9+lxTplnfJVl1n4i/Cw== | ||
| "@apidevtools/[email protected]": |
There was a problem hiding this comment.
Left yarn.lock changes in as it seemed the yarn build ran consistently faster with them
bretterer
approved these changes
Oct 14, 2022
Especially OAuthGrantType in question
….com:okta/okta-sdk-python into jabro-okta-531005-update-oauthgranttype-enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Python SDK does not have the urn:ietf:params:oauth:grant-type:saml2-bearer OAuthGrantType here that the customer cannot create such an OAuth2 Client using the Python SDK.
This PR updates the model generation within
model.py.hbsto handle these cases after updates to the openAPI spec here: okta/okta-management-openapi-spec#148Generated code in OAuthGrantType now looks like this with newly added types:
JIRA: OKTA-531005
Intended to Resolve: #298