OKTA-709693: make userschemaattribute minlength maxlength nullable #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryanapellanes-okta - I'm not seeing code that would resolve #712 ? |
@rcollette Thanks for your patience on this. I apologize for the oversight, I am reviewing this further to address #712. |
|
@rcollette Upon closer inspection the solution to #712 requires additional consideration. I've removed the "fixes" declaration for #712 from this PR. I will investigate further to determine an appropriate fix for #712. |
|
LGTM, @bryanapellanes-okta please confirm the spec changes with the API team before merging. |
laura-rodriguez
approved these changes
May 9, 2024
related spec change https://github.com/atko-eng/okta-oas3/pull/983 |
bryanapellanes-okta
deleted the
OKTA-709693-userschemaattributes-minmaxlength-nullable
branch
laura-rodriguez
added a commit
that referenced
this pull request
May 24, 2024
* Fix "Unable to access IdP links" (#708) * Add support for DPoP (#711) - Add a DPoPProofJwtGenerator class responsbile for DPoP Proof JWT generation - Update OAuthTokenProvider interface and default classes to return an OAuthTokenResponse instead of just the access token - Extend the OAuthTokenResponse with OAuthApiResponse properties. This way, we can parse OAuth errors that come with a different format in comparison with Okta resource APIs - Update the OktaPagedCollectionEnumerator so the DPoP header is added in paginated results when DPoP is enabled - Update the ApiClient.ExecuteWithRetryHeaders to generate a new DPoP JWT when it's applicable - Update templates with the proposed DPoP solution and regenerate the SDK to make sure everything is in place - Add integration tests to cover DPoP scenarios - Add unit tests to cover DPoP scenarios - Update readme with a note about DPoP support * OKTA-709693: make userschemaattribute minlength maxlength nullable (#713) * Rollback policy changes (#717) --------- Co-authored-by: Bryan Apellanes <[email protected]>
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #702