Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling should get a cancelled response. #319

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

JayNewstrom
Copy link
Contributor

Description:

Make a cancelled sign in report as cancelled rather than with an error.

Closes #318

Testing details:

  • Verified basic functionality of change
  • Added tests

Other considerations:

  • Has security implications
  • Has UX changes
RESOLVES:

OKTA-XXXXX

Primary Reviewer(s):

Additional Reviewers:
Security Reviewer(s) (@ okta/rex-team if necessary):
UX Reviewer(s) (if necessary):

@JayNewstrom JayNewstrom merged commit 65ee762 into master May 31, 2022
@JayNewstrom JayNewstrom deleted the jn-cancel branch May 31, 2022 18:23
@idomo1
Copy link

idomo1 commented Jun 6, 2022

Thanks again for the quick fix! It looks like it's working as expected on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when calling WebAuthClient.cancel()
4 participants