Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an idp/role is specified at the CLI, or there is only one anyway then choose it by default #25

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

ctennis
Copy link
Contributor

@ctennis ctennis commented Dec 12, 2022

No description provided.

@ctennis
Copy link
Contributor Author

ctennis commented Dec 12, 2022

Fixes #24

@nickgamb
Copy link

More functionality is already planned here to support multiple AWS environments and profiles.

@monde
Copy link
Collaborator

monde commented Dec 15, 2022

I like this PR. Originally I intended AWS_IAM_IDP and AWS_IAM_ROLE to be presets on the selector but this changes that functionality to skip the selection if you already know your IdP and Role ARNs. That's cool. I'm working on supporting multiple AWS environments fully and this PR will cause a minor merge conflict. That said, I'll pull in this PR so @ctennis gets on the contributor list.

Copy link
Contributor

@MikeMondragon-okta MikeMondragon-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MikeMondragon-okta MikeMondragon-okta merged commit 104e934 into okta:master Dec 15, 2022
@monde monde mentioned this pull request Dec 22, 2022
@monde
Copy link
Collaborator

monde commented Dec 22, 2022

GA v0.1.0 has been released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants