Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DataTable density handling #2177

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Improve DataTable density handling #2177

merged 6 commits into from
Apr 2, 2024

Conversation

jordankoschei-okta
Copy link
Contributor

The density handling had two major inefficiencies:

  1. The CSS was being set on each individual <td>
  2. The table was handling density via both table state and CSS

This PR fixes this by:

  1. Settings the density class on the table body, not the cells
  2. Handling vertical padding on the rows
  3. Removing density from the table state and handling it solely in CSS
  4. Removing the CSS height transition, which was stuttery

@jordankoschei-okta jordankoschei-okta requested a review from a team as a code owner March 19, 2024 01:13
@KevinGhadyani-Okta
Copy link
Contributor

@jordankoschei-okta When you're back, this PR caused a regression when titles are too long:
image

@jordankoschei-okta jordankoschei-okta merged commit 31f4a12 into main Apr 2, 2024
1 of 2 checks passed
@jordankoschei-okta jordankoschei-okta deleted the jk/OKTA-705543 branch April 2, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants