Add missing name prop to TextField
#1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordankoschei-okta
requested review from
ganeshsomasundaram-okta and
kamronbatmanghelich-okta
as code owners
| @@ -130,6 +130,7 @@ const PasswordField = forwardRef<HTMLInputElement, PasswordFieldProps>( | |||
| </InputAdornment> | |||
| } | |||
| id={id} | |||
| name={id} | |||
There was a problem hiding this comment.
Should name always = id?
There was a problem hiding this comment.
For now, I think this is fine. If we find a use case where that doesn't make sense, we can optionally add a name prop as well and do id || name.
KevinGhadyani-Okta
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repurpose
idasnamein form fields.