Added a comment to explain the return on null pid

okorshenko · May 2, 2019 · 8d0a3d8 · 8d0a3d8
1 parent e1525a8
commit 8d0a3d8
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/app/code/Magento/Deploy/Process/Queue.php b/app/code/Magento/Deploy/Process/Queue.php
@@ -336,6 +336,9 @@ private function isDeployed(Package $package)
         if ($this->isCanBeParalleled()) {
             if ($package->getState() === null) {
                 $pid = $this->getPid($package);
+
+                // When $pid comes back as null the child process for this package has not yet started; prevents both
+                // hanging until timeout expires (which was behaviour in 2.2.x) and the type error from strict_types
                 if ($pid === null) {
                     return false;
                 }