[fix] update path resolution to npm #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I liked this module and would like to utilize this in some of my codebases, sending PR to enhance couple of behavior.
: Usually for Windows user who runs different shells will have issues by determining root via
git
can returns shell-specific path like\c\apps\myapp...
. instead, introducedapp-root-path
(https://github.com/inxilpro/node-app-root-path) to resolve root path to application.one thing I noticed is this module calls
npm-which
with name oflinter
asnpmWhich(linter,...)
which causes npm-which fails all time since npm-which expects file to lookup (npm, in this case). Updated to lookup npm, leave fallback to default binPath as-is.