Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hero image params' height issue #768

Merged
merged 1 commit into from
May 23, 2020

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Fix image height not working on hero.asset.

Which issue this PR fixes:
fixes #734

Special notes for your reviewer:

Release note:

- hero: image.height works without an issue now

@mpourismaiel mpourismaiel added this to the v0.18.0 milestone May 22, 2020
@mpourismaiel mpourismaiel requested a review from stp-ip May 22, 2020 16:53
@mpourismaiel mpourismaiel self-assigned this May 22, 2020
@stp-ip stp-ip merged commit 7859847 into okkur:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

hero: Image height is ignored
2 participants