Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of contact fragment submit button #767

Merged

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
Fix alignment of contact fragment submit button when recaptcha is not fully loaded

Which issue this PR fixes:
fixes #722

Special notes for your reviewer:
I'm not sure if this will fix the issue or not. I can't test it locally but in theory it should work. I tried to check whether or not the recaptcha badge is loaded into the dom. Since flex will break when we hide the filler right after if see the recaptcha, checking a deeper element should fix the issue.

Release note:

- contact: fix alignment of contact fragment's submit button when recaptcha is not fully loaded

@mpourismaiel mpourismaiel added this to the v0.18.0 milestone May 22, 2020
@mpourismaiel mpourismaiel requested a review from stp-ip May 22, 2020 16:38
@mpourismaiel mpourismaiel self-assigned this May 22, 2020
@stp-ip stp-ip merged commit 536cb85 into okkur:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Contact form button misaligned when using recaptcha
2 participants