Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list fragment not listing pages from all sections #688

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
List fragment didn't list pages from some sections.

Which issue this PR fixes:
fixes #650

Release note:

- list: Fix list fragment not working on some sections

@mpourismaiel mpourismaiel added this to the v0.16.1 milestone Jan 18, 2020
@mpourismaiel mpourismaiel requested a review from stp-ip January 18, 2020 15:13
@mpourismaiel mpourismaiel self-assigned this Jan 18, 2020
@ghost
Copy link

ghost commented Jan 18, 2020

DeepCode's analysis on #a652ea found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@stp-ip
Copy link
Member

stp-ip commented Jan 18, 2020

Cypress is still failing on this.

@mpourismaiel
Copy link
Member Author

End to end tests take a bit of time to run in containers with limited resources and the time limit I've set for the test runs out. Rerunning the tests fixed the issue.

Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stp-ip stp-ip merged commit e2299bb into okkur:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[blog] root path articles not possible
2 participants