Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languageLang is not in the Hugo documentation, defaultContentLanguage is #684

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

Marzal
Copy link
Contributor

@Marzal Marzal commented Jan 13, 2020

What this PR does / why we need it:
languageLang in exampleSite/config[-dev].toml seems an obsolete option.

Special notes for your reviewer:
I've searched in the Hugo Docs and in the github's repos but I dont' find languageLang anywhere.
defaultContentLanguage is documented and is propably the correct option.

Release note:

Change languageLang to defaultContentLanguage in config.toml

@ghost
Copy link

ghost commented Jan 13, 2020

DeepCode's analysis on #af2bc6 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@stp-ip stp-ip requested a review from mpourismaiel January 13, 2020 17:47
@stp-ip stp-ip added the bug label Jan 13, 2020
@stp-ip stp-ip added this to the v0.16.1 milestone Jan 13, 2020
@mpourismaiel
Copy link
Member

Thanks a lot. I can't find languageLang as well. I'm not sure if it's PascalCase or camelCase since the documentation uses both versions. Let me check it out and get back to you.

@Marzal
Copy link
Contributor Author

Marzal commented Jan 14, 2020

OK.
What I have found is that in the Hugo docs "All Configuration Settings" are in camelCase (I just copy&pasted the setting), also in this PR they favor camelCase and link to a conversation about the topic.

Copy link
Member

@mpourismaiel mpourismaiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thanks a lot for helping us out.

@mpourismaiel mpourismaiel merged commit 685a911 into okkur:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants