-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Using <script type="module"> does not work since v1.0.5 #7
Comments
Only "Fix" I found comes from this |
Thanks for bring the issue to my attention I'll draft a fix for it quickly |
Signed-off-by: Okiki <[email protected]>
## [1.0.7](v1.0.6...v1.0.7) (2024-2-1) ### Bug Fixes * add back support for umd [#7](#7) ([3f1a376](3f1a376))
This should now be fixed, but please use |
Thanks a lot for your quick reaction ! Just tried the |
Awesome 👌 |
Describe the bug
It seems that
window.sharedworker
is not defined by@okikio/sharedworker/lib/index.js
anymore.Console will return an error like :
TypeError: Right side of assignement cannot be destructured
.I had the error on an "old" Safari 15.6 browser.
v1.0.4
but breaks atv1.0.5
on this particular use case./lib
has changed, and does not have the necessary code to support older browser.To Reproduce
Load the script using
<script type="module">
tags exactly as described in the README:Console will return an error like :
TypeError: Right side of assignement cannot be destructured
.Expected behavior
Loading the umd script as described in the docs works, and
window.sharedworker
is defined once@okikio/sharedworker/lib/index.js
orhttps://unpkg.com/@okikio/sharedworker
is loaded.The text was updated successfully, but these errors were encountered: