Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] several edits #92

Merged
merged 2 commits into from
May 12, 2016
Merged

[update] several edits #92

merged 2 commits into from
May 12, 2016

Conversation

gsilvapt
Copy link
Contributor

@gsilvapt gsilvapt commented May 11, 2016

I did some changes to the layouts and added a few guides. It should solve issue #90, #89 and small bits of #87.

If someone could provide some feedback, I'd appreciate that

  • Images are not displaying: Probably a poor use of Jekyll's assets
  • Current structure does not please me - have to think about how to improve it
  • Forgot to add how to make Pull Requests in working-with-git.md to this PR
  • Missing table of contents (don't know how to do it)
  • Menu needs updates (as per Fix left menu bar #91)

short_title: Data Patterns
description: "A collection of tips, tricks and patterns for data work."
short_title: Labs Handbook
description: "A collection of guides, counselling and other advise to participate in OKFN Labs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never use "OKFN" anymore except in URLs. Should always be "Open Knowledge Labs" ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"counselling" is odd phrasing. I would just have:

"Guides and advice on participating in Open Knowledge Labs and its projects"

@rufuspollock
Copy link
Member

@gsilvapt really good work. Some comments inline. General comments:

  • More meaningful commit messages e.g.[update]: several edits does not tell me much suggest: [data][xl]: add several data guides and move all patterns under data-guides/ (note use of "size" descriptor for commit in second bracket [xs,s,m,l,xl] are the options).
  • Slightly less in a single PR would be good -- at least at this early stage -- so I can review, we can make any adjustments and then do the bigger item.
  • I am not sure about relocating all the patterns stuff. This is the kind of thing I really recommend discussing in an issue before just doing. Right now I'll merge but we may need to think about moving it back.
  • All the checklist "issue" items might be better off in a specific issue (given the number and substance of them)

@rufuspollock rufuspollock merged commit a9b40b7 into okfn:gh-pages May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants