This repository has been archived by the owner on Feb 28, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #296. To check which warnings should be fixed I ran
python -Wall manage.py test
. Since we have some dependencies (at this point, justdjango-simple-history
), I updated the libraries locally to make sure the changes are working and the tests are passing.Since it's my first time contributing to Jarbas, it was a good way to know more about the code. :) I wasn't expecting to touch so many parts.
How to test if it really works?
Making sure the tests are passing. Question: should I do any manual tests? I ran it on my machine but I just played around.
TODO
django-simple-history
release a new version with full support to Django 2.0