This repository has been archived by the owner on Feb 28, 2018. It is now read-only.
Update docker container versions #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't able to fully test it without the changes in the Dockerfile's.
cuducos
reviewed
Aug 14, 2017
| @@ -18,6 +18,7 @@ jarbas/frontend/tests/Doc/ | |||
| jarbas/frontend/tests/elm-package.json | |||
| node_modules/ | |||
| staticfiles/ | |||
| assets/ | |||
There was a problem hiding this comment.
AFAIK assets was supposed to be a Docker volume, not an actual directory in project root. Can you refresh my memory here, @lipemorais?
This might me relevant as Django will collect files to ./staticfiles/ (which already exists in the pipeline) — so unifying in one directory might be better than creating a new one…
|
|
||
| RUN npm install yarn | ||
| RUN npm install gulp yarn -D |
There was a problem hiding this comment.
Is -D still a shortcut for --save-dev? If so this might actually change a file in the project root — which might not be expected.
Also related to that error you've asked in PVT, something like gulp not found, installing yarn and gulp as global might be an option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't able to fully test it without the changes in the Dockerfile's.
Dockerfile-elm.