Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: individual reward bands per denom #98

Merged
merged 11 commits into from
Feb 15, 2023

Conversation

adamewozniak
Copy link
Member

Description

closes: #95


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #98 (3e16ca8) into main (0b56c97) will increase coverage by 0.01%.
The diff coverage is 18.58%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   17.11%   17.12%   +0.01%     
==========================================
  Files          40       41       +1     
  Lines       10658    10895     +237     
==========================================
+ Hits         1824     1866      +42     
- Misses       8746     8937     +191     
- Partials       88       92       +4     
Impacted Files Coverage Δ
x/oracle/keeper/params.go 64.28% <0.00%> (ø)
x/oracle/types/oracle.pb.go 0.49% <0.48%> (+<0.01%) ⬆️
x/oracle/abci.go 76.69% <57.14%> (-1.88%) ⬇️
x/oracle/types/params.go 81.72% <81.25%> (-0.50%) ⬇️
x/oracle/types/reward_band.go 86.36% <86.36%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adamewozniak adamewozniak marked this pull request as ready for review February 14, 2023 18:34
@adamewozniak adamewozniak requested a review from a team as a code owner February 14, 2023 18:34
x/oracle/types/denom.go Outdated Show resolved Hide resolved
@adamewozniak adamewozniak requested a review from zarazan February 14, 2023 23:35
@adamewozniak adamewozniak merged commit ad5a237 into main Feb 15, 2023
@adamewozniak adamewozniak deleted the woz/individual-reward-bands branch February 15, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-asset reward band
3 participants