Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Fix set_hvac_mode for systems w/o DHW #85

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Fix set_hvac_mode for systems w/o DHW #85

merged 1 commit into from
Feb 13, 2022

Conversation

oischinger
Copy link
Owner

@oischinger oischinger commented Feb 5, 2022

provide a fallback when setting the hvac mode to ensure only supported vicare_modes are set

@oischinger oischinger mentioned this pull request Feb 5, 2022
Copy link

@Pampasgras Pampasgras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code file, and the change makes sense.
The behaviour is as before, except when vicare_modes are unknown.
I tested this as a custom component and can confirm this fixed my 422 error.

@hnykda
Copy link

hnykda commented Feb 6, 2022

Hey! I am happy to help it as I got pinged from that HA issue - can you give me a hint how I could do it with my HA instance? Should I manually copy it into custom components?

Copy link

@hnykda hnykda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK codewise.

custom_components/vicare/climate.py Outdated Show resolved Hide resolved
@oischinger
Copy link
Owner Author

HA Core PR is here: home-assistant/core#66454

@oischinger oischinger merged commit a076ee4 into master Feb 13, 2022
@oischinger oischinger deleted the fix_hvac_mode branch February 13, 2022 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants