[builtins/unset] Undo the experiment in issue #706 for now.

Still need to figure out what the right behavior is, but this makes spec tests pass again.
oils-for-unix · Apr 15, 2020 · ef69fe6 · ef69fe6
1 parent aac8712
commit ef69fe6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/state.py b/core/state.py
@@ -1428,7 +1428,7 @@ def Unset(self, lval, lookup_mode, strict):
 
     with tagswitch(lval) as case:
       if case(lvalue_e.Named):  # unset x
-        if 0:  # flip this
+        if 1:  # flip this to experiment
           # This behavior is good for test/spec.sh assign -r 24-27
           name_map[cell_name].val = value.Undef()
           cell.exported = False

diff --git a/test/spec.sh b/test/spec.sh
@@ -416,7 +416,7 @@ builtin-dirs() {
 }
 
 builtin-vars() {
-  sh-spec spec/builtin-vars.test.sh --osh-failures-allowed 1 \
+  sh-spec spec/builtin-vars.test.sh --osh-failures-allowed 2 \
     ${REF_SHELLS[@]} $ZSH $OSH_LIST "$@"
 }