Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish fat jar #22

Merged
merged 4 commits into from
Jan 31, 2018
Merged

Publish fat jar #22

merged 4 commits into from
Jan 31, 2018

Conversation

laughedelic
Copy link
Contributor

Fixes #21. A short-term solution: in addition to normal artifacts, add a fat-jar. It won't require an additional resolver because it includes all dependencies.

@laughedelic laughedelic self-assigned this Oct 19, 2017
@laughedelic
Copy link
Contributor Author

@jvican I just published v0.5.1 with a fat-jar. You can try

addSbtPlugin("ohnosequences" % "sbt-github-release" % "0.5.1" classifier "fat" intransitive())

It seems to work fine, but gives me a warning (only the first time it loads):

[warn] Found intransitive dependency (ohnosequences:sbt-github-release:0.5.1 intransitive (e:sbtVersion=1.0, e:scalaVersion=2.12)) while publishMavenStyle is true, but Maven repositories
[warn]   do not support intransitive dependencies. Use exclusions instead so transitive dependencies
[warn]   will be correctly excluded in dependent projects.
[warn]

I'm not sure if it's ok, or it has to be fixed. As far as I understand it's talking about publishMavenStyle in the project/plugins.sbt (which is not supposed to be published, right?). So I just add

publishMavenStyle := false

and the warning doesn't appear.

@jvican
Copy link
Contributor

jvican commented Oct 20, 2017

Great investigation. Yeah, it seems that such a warning is a little bit misleading. I wonder why publishMavenStyle is true in sbt meta projects. I think this issue is worth a new sbt/sbt ticket.

Thanks for the release! 🎉

@laughedelic
Copy link
Contributor Author

I don't remember why I haven't merged this.. 🤔

@laughedelic laughedelic merged commit bd09e77 into master Jan 31, 2018
@laughedelic laughedelic deleted the publish-fat-jar branch January 31, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of the extra resolver
2 participants