Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): adding new nekonight variant the nekonight moon and adding pull request template/issue template #653

Merged
merged 19 commits into from
Jan 25, 2025

Conversation

bgcicca
Copy link
Contributor

@bgcicca bgcicca commented Jan 21, 2025

adding new nekonight variant the nekonight moon, Based on the cupcake, another new variant came along, the last one of the night.

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 21, 2025

adding new nekonight variant the nekonight moon, Based on the cupcake, another new variant came along, the last one of the night.

Now I'm going to sleep because it's 1:43 am here in Brazil, tomorrow we'll see

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 21, 2025

I am back

@akinomyoga
Copy link
Contributor

Could you follow the first paragraph of the "New Theme" section of CONTRIBUTING.md? The contents of the theme file are almost identical with nekonight, and only the icon seems different. In this case, one can simply overwrite the icon_* variables. The branch icon in the function _omb_theme_nekonight_git_prompt_info is also different, but in this case, please modify the nekonight theme to offer a variable for the branch icon.

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 21, 2025

Could you follow the first paragraph of the "New Theme" section of CONTRIBUTING.md? The contents of the theme file are almost identical with nekonight, and only the icon seems different. In this case, one can simply overwrite the icon_* variables. The branch icon in the function _omb_theme_nekonight_git_prompt_info is also different, but in this case, please modify the nekonight theme to offer a variable for the branch icon.

Did you mean putting everything in the same file and overwriting the icon, like I would put a conditional and then depending on one icon and depending on another? it would be more interesting

@akinomyoga
Copy link
Contributor

Did you mean putting everything in the same file and overwriting the icon, like I would put a conditional and then depending on one icon and depending on another? it would be more interesting

No. Please source themes/nekonight/nekonight.theme.sh from themes/nekonight-moon/nekonight-moon.theme.sh. Then you can simply overwrite a few icon_* variables.

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 21, 2025

Did you mean putting everything in the same file and overwriting the icon, like I would put a conditional and then depending on one icon and depending on another? it would be more interesting

No. Please source themes/nekonight/nekonight.theme.sh from themes/nekonight-moon/nekonight-moon.theme.sh. Then you can simply overwrite a few icon_* variables.

aaa, ok, I'll do that, I'll update here, I'm writing the documentation, even if you want help with the doc website, I'm studying web development and it would be cool to learn

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 21, 2025

I'm experiencing some errors, and it may take a while for me to fix, but I'll update the progress here.

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 22, 2025

I managed to tidy it up and modularize it, so I can reuse the base in more themes

themes/nekonight/nekonight-base.sh Outdated Show resolved Hide resolved
themes/nekonight/nekonight.theme.sh Outdated Show resolved Hide resolved
themes/nekonight_moon/nekonight_moon.theme.sh Outdated Show resolved Hide resolved
themes/nekonight_moon/nekonight_moon.theme.sh Outdated Show resolved Hide resolved
… overwritten to allow greater permissiveness when customizing
@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 22, 2025

I think now it will be easier to do the others I'm planning

themes/nekonight/nekonight.theme.sh Show resolved Hide resolved
themes/nekonight/nekonight.theme.sh Outdated Show resolved Hide resolved
themes/nekonight/nekonight-base.sh Outdated Show resolved Hide resolved
themes/nekonight/nekonight-base.sh Outdated Show resolved Hide resolved
@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 22, 2025

You're right, it really does get better...

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 22, 2025

What do you think about making a group on discord?

@akinomyoga
Copy link
Contributor

I don't use Discord, so I don't check messages in Discord regularly. Even if someone would write messages, I respond after several days, which I think is not useful. On the other hand, I'm mostly on GitHub all the time.

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 22, 2025

I don't use Discord, so I don't check messages in Discord regularly. Even if someone would write messages, I respond after several days, which I think is not useful. On the other hand, I'm mostly on GitHub all the time.

so it would be a good idea to open a discussion here on github, it might be good for contributors to discuss their ideas

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 22, 2025

I don't use Discord, so I don't check messages in Discord regularly. Even if someone would write messages, I respond after several days, which I think is not useful. On the other hand, I'm mostly on GitHub all the time.

so it would be a good idea to open a discussion here on github, it might be good for contributors to discuss their ideas

I only noticed now that it's already open

@akinomyoga
Copy link
Contributor

akinomyoga commented Jan 22, 2025

so it would be a good idea to open a discussion here on github,

Yes.

it might be good for contributors to discuss their ideas

Yes. You can open a discussion at https://github.com/ohmybash/oh-my-bash/discussions.

GitHub Discussion is also useful because the discussions there will automatically be indexed by search engines (such as Google) so that users can find a discussion while searching the web globally.

P.S.

Discord discussions are usually unreachable with search engines.

Discourse (used in the Rust community) is web-based, so I noticed that it allows indexing to some extent, but the search engines don't seem to crawl Discourse discussions properly. They can crawl a discussion only when there is an external link on the web to that specific discussion.

I only noticed now that it's already open

Ah, yes.

themes/nekonight/nekonight-base.sh Outdated Show resolved Hide resolved
themes/THEMES.md Outdated Show resolved Hide resolved
themes/nekonight_moon/nekonight-moon-dark.jpg Outdated Show resolved Hide resolved
themes/nekonight_moon/nekonight_moon.theme.sh Outdated Show resolved Hide resolved
themes/nekonight/nekonight.theme.sh Outdated Show resolved Hide resolved
themes/nekonight/nekonight-base.sh Outdated Show resolved Hide resolved
themes/nekonight/nekonight.theme.sh Show resolved Hide resolved
themes/nekonight_moon/nekonight_moon.theme.sh Show resolved Hide resolved
themes/nekonight_moon/nekonight_moon.theme.sh Outdated Show resolved Hide resolved
@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 23, 2025

see if this is better

@bgcicca bgcicca requested a review from akinomyoga January 23, 2025 04:50
@bgcicca bgcicca changed the title feat(themes): adding new nekonight variant the nekonight moon feat(themes): adding new nekonight variant the nekonight moon and adding pull request template/issue template Jan 23, 2025
.github/ISSUE_TEMPLATE/BUG_REPORT.md Outdated Show resolved Hide resolved
themes/THEMES.md Outdated Show resolved Hide resolved
@bgcicca bgcicca requested a review from akinomyoga January 23, 2025 18:36
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now looks good. Please check the following point.

themes/nekonight_moon/nekonight_moon.theme.sh Show resolved Hide resolved
@akinomyoga
Copy link
Contributor

I'll check it later again and will merge. Thanks!

@bgcicca
Copy link
Contributor Author

bgcicca commented Jan 23, 2025

I'll check it later again and will merge. Thanks!

I thank you

@akinomyoga akinomyoga merged commit 569a6f5 into ohmybash:master Jan 25, 2025
4 checks passed
@akinomyoga
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants