Escaped <> in attributes

CHANGELOG.md

@@ -1,4 +1,8 @@
 
+## 2.8.3 - March 3, 2018
+
+  - Attribute values now escape < and > on dump.
+
 ## 2.8.2 - November 1, 2017
 
   - Fixed bug with SAX parser that caused a crash with very long invalid instruction element.

ext/ox/dump.c

@@ -92,7 +92,7 @@ static const char	xml_friendly_chars[257] = "\
 
 static const char	xml_quote_chars[257] = "\
 :::::::::11::1::::::::::::::::::\
-11611151111111111111111111111111\
+11611151111111111111111111114141\
 11111111111111111111111111111111\
 11111111111111111111111111111111\
 11111111111111111111111111111111\

ext/ox/sax_buf.h

@@ -44,7 +44,7 @@ extern int	ox_sax_buf_read(Buf buf);
 
 static inline char
 buf_get(Buf buf) {
-    //printf("*** drive get from '%s'  from start: %ld  buf: %p  from read_end: %ld\n", buf->tail, buf->tail - buf->head, buf->head, buf->read_end - buf->tail);
+    printf("*** drive get from '%s'  from start: %ld  buf: %p  from read_end: %ld\n", buf->tail, buf->tail - buf->head, buf->head, buf->read_end - buf->tail);
     if (buf->read_end <= buf->tail) {
         if (0 != ox_sax_buf_read(buf)) {
             return '\0';

lib/ox/version.rb

@@ -1,5 +1,5 @@
 
 module Ox
   # Current version of the module. 
-  VERSION = '2.8.2'
+  VERSION = '2.8.3'
 end

test/tests.rb

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-# encoding: UTF-8
+# encoding: utf-8
 
 # Ubuntu does not accept arguments to ruby when called using env. To get warnings to show up the -w options is
 # required. That can be set in the RUBYOPT environment variable.
@@ -374,7 +374,8 @@ def test_escape_value
     doc = Ox.parse(xml)
     assert_equal('<&test>', doc.attributes[:name])
     dumped_xml = Ox.dump(doc)
-    assert_equal(xml, dumped_xml)
+    escaped_xml = %{\n<top name="&lt;&amp;test&gt;">&lt;not \'quoted\'&gt;</top>\n}
+    assert_equal(escaped_xml, dumped_xml)
   end
 
   def test_escape_bad