Issues reported by awesome-lint #107
Assignees
Comments
mgrojo
added a commit
that referenced
this issue
Feb 25, 2023
These issues go in the categories: - Important ones to be solved. - Puristic ones easy to solve. See issue #107
mgrojo
added a commit
that referenced
this issue
Feb 25, 2023
mgrojo
added a commit
that referenced
this issue
Feb 25, 2023
Left only in the Embedded section, since it of most interest in that area than as a general sound library. ``` README.md:592:3: https://github.com/raph-amiard/ada-synth-lib remark-lint:double-link README.md:653:3: https://github.com/raph-amiard/ada-synth-lib remark-lint:double-link ``` See issue #107
This was referenced Feb 25, 2023
|
I directly fixed the non-controversial issues and have made pull requests with the ones requiring review. These are the only remaining issues if everything is merged: This can be solved adding the corresponding tag, that can only be done by the owner. These seem like a bug in how the linter interprets URLs. See Scrum/remark-lint-double-link#10 |
mgrojo
added a commit
that referenced
this issue
Feb 25, 2023
Fixes these occurrences: ``` ✖ 266:122 https://github.com/AdaCore/ada_language_server remark-lint:double-link ✖ 289:3 Invalid list item link remark-lint:awesome-list-item ✖ 302:69 List item description must start with valid casing remark-lint:awesome-list-item ✖ 322:3 Invalid list item link remark-lint:awesome-list-item ✖ 343:3 Invalid list item link remark-lint:awesome-list-item ✖ 346:3 Invalid list item link remark-lint:awesome-list-item ✖ 350:3 Invalid list item link remark-lint:awesome-list-item ✖ 384:3 Invalid list item link remark-lint:awesome-list-item ✖ 402:3 Invalid list item link remark-lint:awesome-list-item ✖ 449:3 https://github.com/AdaCore/ada_language_server remark-lint:double-link ✖ 492:3 Invalid list item link remark-lint:awesome-list-item ✖ 523:3 Invalid list item link remark-lint:awesome-list-item ✖ 537:3 Invalid list item link remark-lint:awesome-list-item ✖ 562:3 Invalid list item link remark-lint:awesome-list-item ✖ 573:3 Invalid list item link remark-lint:awesome-list-item ✖ 574:3 Invalid list item link remark-lint:awesome-list-item ✖ 590:3 Invalid list item link remark-lint:awesome-list-item ✖ 695:3 Invalid list item link remark-lint:awesome-list-item ✖ 724:3 Invalid list item link remark-lint:awesome-list-item ✖ 725:3 Invalid list item link remark-lint:awesome-list-item ✖ 735:3 Invalid list item link remark-lint:awesome-list-item ✖ 736:3 Invalid list item link remark-lint:awesome-list-item ``` See issue #107
mgrojo
added a commit
to mgrojo/awesome-ada
that referenced
this issue
Mar 4, 2023
Fixes these occurrences: ``` ✖ 266:122 https://github.com/AdaCore/ada_language_server remark-lint:double-link ✖ 289:3 Invalid list item link remark-lint:awesome-list-item ✖ 302:69 List item description must start with valid casing remark-lint:awesome-list-item ✖ 322:3 Invalid list item link remark-lint:awesome-list-item ✖ 343:3 Invalid list item link remark-lint:awesome-list-item ✖ 346:3 Invalid list item link remark-lint:awesome-list-item ✖ 350:3 Invalid list item link remark-lint:awesome-list-item ✖ 384:3 Invalid list item link remark-lint:awesome-list-item ✖ 402:3 Invalid list item link remark-lint:awesome-list-item ✖ 449:3 https://github.com/AdaCore/ada_language_server remark-lint:double-link ✖ 492:3 Invalid list item link remark-lint:awesome-list-item ✖ 523:3 Invalid list item link remark-lint:awesome-list-item ✖ 537:3 Invalid list item link remark-lint:awesome-list-item ✖ 562:3 Invalid list item link remark-lint:awesome-list-item ✖ 573:3 Invalid list item link remark-lint:awesome-list-item ✖ 574:3 Invalid list item link remark-lint:awesome-list-item ✖ 590:3 Invalid list item link remark-lint:awesome-list-item ✖ 695:3 Invalid list item link remark-lint:awesome-list-item ✖ 724:3 Invalid list item link remark-lint:awesome-list-item ✖ 725:3 Invalid list item link remark-lint:awesome-list-item ✖ 735:3 Invalid list item link remark-lint:awesome-list-item ✖ 736:3 Invalid list item link remark-lint:awesome-list-item ``` See issue ohenley#107
|
There's still a pending issue reported by the linter: README.md:1:1 @ohenley I think this can only be fixed by you. |
|
@ohenley hace you missed this? It should only take a minute. |
|
Yep missed it. Did add "awesome-list" as a GitHub topic. |
|
Great! Everything is passing now, except a timeout in https://www.ada-europe.org/ which I hope is a transitory problem. Closing this, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The awesome-lint program has run for the first time; I wasn't aware of those issues. It seems the link checker was aborting the action.
https://github.com/ohenley/awesome-ada/actions/runs/4267389929/jobs/7428942700
There are some legitimate and important issues to be fixed:
Other puristic ones, but easy to solve.
A few looks like there's some bug in awesome-lint.
And finally, other ones that I'm not sure if they should be solved: either because they would affect presentation or because we would lose something, like a second link to the same URL. It doesn't like either the out-of-place links that I precisely included to centralize the URL, so I don't see a solution for those.
I'll try to clean the important and easy ones, and we should discuss the remaining: whether there's a way to fix them, the rule can be disabled or the lint has to be removed altogether.
The text was updated successfully, but these errors were encountered: