-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scroll and responsiveness to the plots page #9815
Closed
Utkarsh-Anandani
wants to merge
8
commits into
ohcnetwork:develop
from
Utkarsh-Anandani:issues/#9788/Alignment-of-plots-and-overflowing
+14
−8
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1a6607d
Added scroll and responsiveness to the plots page
Utkarsh-Anandani 623d7d1
used useWindowDimensions hook
Utkarsh-Anandani 24ce109
used useBreakpoints hook instead of useWindowDimensions
Utkarsh-Anandani b6480b1
Merge branch 'develop' into issues/#9788/Alignment-of-plots-and-overf…
Utkarsh-Anandani fbdad74
requested changes
Utkarsh-Anandani 8eb6c3e
updates
Utkarsh-Anandani 8b30429
Merge branch 'ohcnetwork:develop' into issues/#9788/Alignment-of-plot…
Utkarsh-Anandani 4bf98ec
Merge branch 'issues/#9788/Alignment-of-plots-and-overflowing' of htt…
Utkarsh-Anandani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
used useBreakpoints hook instead of useWindowDimensions
commit 24ce109df1907c6aa97b1b216dcb4872d39c824c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -11,7 +11,7 @@ import { | |||||
} from "@/components/Common/Charts/ObservationChart"; | ||||||
import Loading from "@/components/Common/Loading"; | ||||||
|
||||||
import useWindowDimensions from "@/hooks/useWindowDimensions"; | ||||||
import useBreakpoints from "@/hooks/useBreakpoints"; | ||||||
|
||||||
import { EncounterTabProps } from "@/pages/Encounters/EncounterShow"; | ||||||
|
||||||
|
@@ -23,7 +23,7 @@ export const EncounterPlotsTab = (props: EncounterTabProps) => { | |||||
const { t } = useTranslation(); | ||||||
const [qParams, setQParams] = useQueryParams<QueryParams>(); | ||||||
|
||||||
const { width } = useWindowDimensions(); | ||||||
const isSmallDevice = useBreakpoints({ default: true, md: false }); | ||||||
|
||||||
const { data, isLoading } = useQuery<ObservationPlotConfig>({ | ||||||
queryKey: ["plots-config"], | ||||||
|
@@ -62,7 +62,7 @@ export const EncounterPlotsTab = (props: EncounterTabProps) => { | |||||
<ObservationVisualizer | ||||||
patientId={props.patient.id} | ||||||
codeGroups={tab.groups} | ||||||
gridCols={width >= 768 ? 2 : 1} | ||||||
gridCols={isSmallDevice ? 1 : 2} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
/> | ||||||
</TabsContent> | ||||||
))} | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.