-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DateInput and Actions button not optimised for mobile viewports #9432
fix: DateInput and Actions button not optimised for mobile viewports #9432
Conversation
WalkthroughThis pull request addresses mobile viewport optimization for the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/components/Common/DateInputV2.tsx (1)
291-291
: LGTM! Consider consolidating duplicate responsive classes.The responsive positioning classes effectively handle the date picker's position across different viewport sizes. However, there's a minor optimization opportunity.
Consider consolidating the duplicate translation classes:
-return `${right ? "sm:-translate-x-1/2" : ""} ${top ? "md:-translate-y-[calc(100%+50px)]" : ""} ${right ? "max-sm:-translate-x-1/2" : ""} ${top ? "max-sm:-translate-y-[calc(100%+50px)]" : ""}`.trim(); +return `${right ? "-translate-x-1/2" : ""} ${top ? "-translate-y-[calc(100%+50px)]" : ""}`.trim();The simplified version achieves the same responsive behavior since the translation will apply across all screen sizes, which is what we want for both cases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/Common/DateInputV2.tsx
(1 hunks)src/components/Patient/PatientHome.tsx
(1 hunks)
🔇 Additional comments (1)
src/components/Patient/PatientHome.tsx (1)
455-455
: LGTM! Improved mobile layout with centered alignment.
The change from mx-3
to mx-auto
effectively centers the actions section, providing better visual balance on mobile viewports.
LGTM |
@harshit078 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
DateInputV2
component for improved responsive design.UserAutocomplete
component in thePatientHome
for volunteer selection.Bug Fixes
PatientHome
component for better alignment.