Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for List View in Shifting from Gird LayOut to List Layout #8882

Merged
merged 34 commits into from
Nov 11, 2024

Conversation

AnveshNalimela
Copy link
Contributor

@AnveshNalimela AnveshNalimela commented Oct 22, 2024

Proposed Changes

-Aligned the components in shifitng and resource page
-Increased the search bar size in list view
-Adjusted the componets
-Changed the font to semibold in Resource card
-Changed the gridlayout from 2 cols to 3 cols to remove extra white space

@ohcnetwork/care-fe-code-reviewers
Before:
{FEF5B5E5-6B5B-4DA0-968E-4AE59C51DC1E}
After:
image

Story points Requesting: 2 points

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Enhanced the ListView component to display detailed patient information, shifting status, and facility details.
    • Added localization support for contact information with the new entry "contact_info": "Contact Info".
  • Bug Fixes

    • Improved rendering logic for shifting cards, simplifying conditional rendering for empty data states.
  • Chores

    • Updated the .env configuration file with comments for clarity and organization of environment variables.

@AnveshNalimela AnveshNalimela requested a review from a team as a code owner October 22, 2024 16:32
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit fdc0a24
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67320785aa0067000811260f
😎 Deploy Preview https://deploy-preview-8882--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnveshNalimela AnveshNalimela changed the title Resloved the UI and Changed GRID 3 cols Alignment of components and Changed GRID layout 3 cols in shifiting Oct 22, 2024
Copy link

👋 Hi, @AnveshNalimela,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
@bodhish
Copy link
Member

bodhish commented Oct 23, 2024

If we are making this change, I would really make it a list ie like a table; than have a grid;

image

CC @nihal467 @gigincg @rithviknishad

@AnveshNalimela
Copy link
Contributor Author

Any Changes required if yes. Suggest

@bodhish
Copy link
Member

bodhish commented Oct 27, 2024

@AnveshNalimela Please use the reference UI shared to update the list view.

@AnveshNalimela
Copy link
Contributor Author

AnveshNalimela commented Oct 27, 2024

{5BB5DB58-D088-4200-BF7E-200A5B01FFB2}
@bodhish Have a look

@AnveshNalimela AnveshNalimela changed the title Alignment of components and Changed GRID layout 3 cols in shifiting Redesign UI for List View in Shifting Oct 27, 2024
src/Components/Shifting/ListView.tsx Outdated Show resolved Hide resolved
src/Components/Shifting/ListView.tsx Outdated Show resolved Hide resolved
@rithviknishad rithviknishad merged commit 25c8e0b into ohcnetwork:develop Nov 11, 2024
5 checks passed
Copy link

@AnveshNalimela Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@AnveshNalimela AnveshNalimela deleted the issue/8832/ui-align branch December 11, 2024 14:02
@coderabbitai coderabbitai bot mentioned this pull request Dec 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design the List View in Shifting Page
7 participants