Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cancel button for ValueSet Creation #10917

Closed
wants to merge 32 commits into from

Conversation

Tanuj1718
Copy link
Contributor

@Tanuj1718 Tanuj1718 commented Mar 1, 2025

Proposed Changes

Screen.Recording.2025-03-01.at.7.46.47.PM.mov

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features
    • Enhanced form navigation by adding a cancel button alongside the submit action.
    • The cancel option allows users to easily exit the form and return to the administration overview page.
    • Introduced a clear visual indicator for canceling actions with an icon and styled button.

Tanuj1718 and others added 30 commits February 4, 2025 00:21
@Tanuj1718 Tanuj1718 requested a review from a team as a code owner March 1, 2025 14:20
Copy link
Contributor

coderabbitai bot commented Mar 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the ValueSetForm component by integrating navigation functionality. The component now imports useNavigate from the raviger library and initializes a navigate function within the form. The UI has been updated to replace a single submit button with a flex container that includes both a submit and a cancel button. The cancel button, styled with an outline and paired with a left-pointing CareIcon, triggers programmatic navigation to the /admin/valuesets route when clicked.

Changes

File(s) Change Summary
src/components/ValueSet/ValueSetForm.tsx Added import for useNavigate from raviger, initialized navigate function, and replaced the single submit button with a flex container including a cancel button that navigates to /admin/valuesets.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant VF as ValueSetForm
    participant R as raviger

    U->>VF: Clicks Cancel Button
    VF->>R: Calls navigate('/admin/valuesets')
    R-->>VF: Route change executed
Loading

Possibly related PRs

Suggested labels

needs testing, needs review

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

I'm a rabbit with a hop so light,
New navigation makes my day bright.
A cancel button now leads the way,
To routes where forms gracefully sway.
Code leaps and bounds, oh what a sight!
Hoppin’ with joy in the digital night.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39bb22a and c64905f.

📒 Files selected for processing (1)
  • src/components/ValueSet/ValueSetForm.tsx (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Mar 1, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c64905f
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67c317c97581630008063160
😎 Deploy Preview https://deploy-preview-10917.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member

already solved, also why are there so many unnecessary commits?

@Tanuj1718
Copy link
Contributor Author

already solved, also why are there so many unnecessary commits?

Yeah, PR was not raised when I saw it.
These commits are because I have solved my first few issues in develop branch. After that I realised that we should create new branch for each issue. So those commits are visible in every new branch which I create using develop.

@github-actions github-actions bot added needs-triage question Further information is requested labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New ValueSet should have a cancel button
4 participants