Show hyphen when no severity in SymptomTable #10662

rajku-dev · 2025-02-17T22:17:12Z

Proposed Changes

Fixes Fix symptoms table for missing severeity #10660
@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Bug Fixes
- Improved symptom severity display to show a placeholder ("-") when data is missing. This update ensures that missing or undefined severity values are clearly indicated in the view.

coderabbitai · 2025-02-17T22:17:20Z

"""

Walkthrough

This pull request updates the SymptomTable component by modifying how the severity badge is rendered. The change introduces a conditional expression that checks if symptom.severity is truthy. If it is, the severity is displayed within the Badge component; otherwise, a hyphen ("-") is rendered instead. No public or exported entity declarations were affected.

Changes

File	Change Summary
`src/.../SymptomTable.tsx`	Updated severity badge rendering: now uses a conditional check to display severity or "-" if not defined.

Sequence Diagram(s)

sequenceDiagram
    participant SymptomTable as Component
    participant UI as UserInterface

    SymptomTable->>SymptomTable: Check if symptom.severity exists?
    alt Severity exists
        SymptomTable->>UI: Render severity badge
    else Severity missing
        SymptomTable->>UI: Render "-" as placeholder
    end

Poem

I'm a little rabbit in the code field so neat,
Hopping through changes with agile little feet.
I see conditionals where once was a plain line,
Turning severity to a hyphen when it's not fine.
Carrot cheers to clean code—oh, isn't it divine!
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 308fc4b and b76e301.

📒 Files selected for processing (1)

src/components/Patient/symptoms/SymptomTable.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Patient/symptoms/SymptomTable.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-17T22:17:34Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`b76e301`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67b3baca392a3a0008dc3110
😎 Deploy Preview	https://deploy-preview-10662.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…rity-nullity-check

…om/rajku-dev/care_fe into issue/10660/severity-nullity-check

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Patient/symptoms/SymptomTable.tsx (1)
81-81: LGTM! The implementation correctly handles empty severity cases.

The change aligns with the PR objective and follows the existing pattern in the codebase for handling empty values.

Consider using nullish coalescing for better type safety.

For better type safety and to handle both undefined and null cases explicitly:
-{symptom.severity ? t(symptom.severity) : "-"}
+{symptom.severity ?? "-"}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cc9168 and 308fc4b.

📒 Files selected for processing (1)

src/components/Patient/symptoms/SymptomTable.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Test
GitHub Check: CodeQL-Build
GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

sainak

@rajku-dev wrap the badge in the condition

github-actions · 2025-02-18T05:42:30Z

@rajku-dev Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Show hyphen when no severity in SymptonTable

8f38824

rajku-dev requested a review from a team as a code owner February 17, 2025 22:17

rajku-dev and others added 3 commits February 18, 2025 03:48

Merge branch 'develop' into issue/10660/severity-nullity-check

b1babbc

Merge remote-tracking branch 'upstream/develop' into issue/10660/seve…

b1cb0ce

…rity-nullity-check

Merge branch 'issue/10660/severity-nullity-check' of https://github.c…

308fc4b

…om/rajku-dev/care_fe into issue/10660/severity-nullity-check

coderabbitai bot reviewed Feb 17, 2025

View reviewed changes

sainak reviewed Feb 17, 2025

View reviewed changes

wrap badge instead

b76e301

rajku-dev requested a review from sainak February 17, 2025 22:41

rajku-dev changed the title ~~Show hyphen when no severity in SymptonTable~~ Show hyphen when no severity in SymptomTable Feb 17, 2025

rithviknishad approved these changes Feb 18, 2025

View reviewed changes

rithviknishad added the needs review label Feb 18, 2025

Jacobjeevan approved these changes Feb 18, 2025

View reviewed changes

Jacobjeevan added needs testing and removed needs review labels Feb 18, 2025

rithviknishad merged commit fc9e022 into ohcnetwork:develop Feb 18, 2025
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show hyphen when no severity in SymptomTable #10662

Show hyphen when no severity in SymptomTable #10662

rajku-dev commented Feb 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 17, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 17, 2025 •

edited

Loading

coderabbitai bot left a comment

sainak left a comment

github-actions bot commented Feb 18, 2025

Show hyphen when no severity in SymptomTable #10662

Show hyphen when no severity in SymptomTable #10662

Conversation

rajku-dev commented Feb 17, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 17, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 17, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

sainak left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 18, 2025

rajku-dev commented Feb 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 17, 2025 •

edited

Loading