Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge autocomplete options; Fixes facility select in resource form edge case #10646

rithviknishad · 2025-02-17T10:15:12Z

Proposed Changes

Issue reported by @nihal467

Fixes autocomplete unable to pre-fill in certain usages due to it's default filtering behaviour based on value. Eg. all usages of Geo Organization Selector
Adds utility fn. to merge autocomplete options when used along with search / paginated APIs when elements are not present in first page during pre-fill / edit forms.
Fixes the same for facility select in resource form

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced autocomplete suggestions for facility selection. Now, if a facility is chosen, it seamlessly appears within the options list without duplicates.
- Updated the display format for suggestions to clearly show both descriptive labels and corresponding values, improving clarity and user experience.

coderabbitai · 2025-02-17T10:15:21Z

Walkthrough

The changes introduce a new utility function mergeAutocompleteOptions that conditionally merges a selected option into an existing options array, preventing duplicates. This function is then leveraged in the ResourceForm component to ensure that a pre-selected facility is included in the autocomplete suggestions. Additionally, the Autocomplete component has been updated to display options in a formatted "label - value" style and to adjust its selection logic accordingly.

Changes

File(s)	Change Summary
`src/Utils/utils.ts`	Added new function `mergeAutocompleteOptions` to merge a selected option with the existing options array while preventing duplicate entries.
`src/components/Resource/ResourceForm.tsx`	Updated the component to import and use `mergeAutocompleteOptions` so that a pre-selected facility is included in the autocomplete options if needed.
`src/components/ui/autocomplete.tsx`	Modified option display formatting to "label - value" and updated selection logic to find options based on the new formatted string.

Sequence Diagram(s)

sequenceDiagram
    participant RF as ResourceForm
    participant UT as mergeAutocompleteOptions (utils.ts)
    participant AC as Autocomplete Component
    participant U  as User

    RF->>UT: Call mergeAutocompleteOptions(facilityOptions, selectedValue)
    UT-->>RF: Return mergedOptions
    RF->>AC: Pass mergedOptions to Autocomplete
    AC->>U: Display options ("label - value")
    U->>AC: Select an option
    AC-->>U: Return selected option

Poem

I'm a bunny with a coding delight,
Hopping through changes from morning to night.
Merging options like carrots in a row,
"Label - value" shines with a glow.
In every line, the code does play—
A playful dance in a brilliant array!
🐇✨

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-17T10:15:35Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`5a109fc`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67b30c34d667a30008f7b966
😎 Deploy Preview	https://deploy-preview-10646.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/ui/autocomplete.tsx (1)
72-76: Consider using a more efficient value handling approach.

The current implementation combines and then splits the label and value, which is inefficient. Consider passing the option object directly to maintain the relationship between label and value without string manipulation.
-value={`${option.label} - ${option.value}`}
-onSelect={(v) => {
-  const currentValue =
-    options.find((o) => `${o.label} - ${o.value}` === v)?.value ||
-    "";
+value={option.value}
+onSelect={(v) => {
+  const currentValue = v || "";

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fd6849 and 5a109fc.

📒 Files selected for processing (3)

src/Utils/utils.ts (1 hunks)
src/components/Resource/ResourceForm.tsx (2 hunks)
src/components/ui/autocomplete.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (2)

src/Utils/utils.ts (1)

245-252: LGTM!

The utility function is well-implemented with proper handling of edge cases and duplicate prevention.

src/components/Resource/ResourceForm.tsx (1)

278-286: LGTM!

The integration of mergeAutocompleteOptions effectively solves the pre-fill issue by ensuring the selected facility is included in the options.

cypress · 2025-02-17T10:28:07Z

CARE Run #4831

Run Properties: Failed #4831 • 5a109fc98e: Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge...

Project	`CARE`
Branch Review	`rithviknishad/fix/autocomplete-and-resource-form-facility-pre-fill`
Run status	`Failed #4831`
Run duration	`10m 20s`
Commit	`5a109fc98e: Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge...`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`10`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`1`
View all changes introduced in this branch ↗︎

Tests for review

patient_spec/patient_creation.cy.ts • 6 failed tests

View Output

Test		Artifacts
Patient Management > creates a new non-binary patient \| O+ blood group \| multi-line address and verifies registration		`Test Replay` `Screenshots`
Patient Management > creates a new transgender patient \| AB+ blood group \| with emergency contact and verifies registration		`Test Replay` `Screenshots`
Patient Management > creates a new female patient \| different addresses \| same phone number and verifies registration		`Test Replay` `Screenshots`
Patient Management > creates a new standard male patient \| same address \| different emergency contact and verifies registration		`Test Replay` `Screenshots`
Patient Management > Search patient with phone number and create a new encounter		`Test Replay` `Screenshots`
Patient Management > Edit a patient details and verify the changes		`Test Replay` `Screenshots`

facility_spec/facility_creation.cy.ts • 1 failed test

View Output

Test		Artifacts
Facility Management > Create a new facility using the admin role and verify validation errors		`Test Replay` `Screenshots`

patient_spec/patient_details.cy.ts • 1 failed test

View Output

Test		Artifacts
Patient Management > Assign users to a patient		`Test Replay` `Screenshots`

patient_spec/patient_encounter.cy.ts • 1 failed test

View Output

Test		Artifacts
Patient Encounter Questionnaire > Create a new ABG questionnaire and verify the values		`Test Replay` `Screenshots`

users_spec/user_creation.cy.ts • 1 failed test

View Output

Test		Artifacts
User Creation > should create a new user successfully		`Test Replay` `Screenshots`

nihal467 · 2025-02-17T10:30:35Z

LGTM

khavinshankar · 2025-02-17T12:21:52Z

@nihal467 @rithviknishad Cypress tests are failing, is this expected?

github-actions · 2025-02-17T12:26:46Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

rithviknishad added 2 commits February 17, 2025 15:24

Fixes resource form unable to pre-fill facility if beyond 1st page

ae6a04c

fix autocomplete options being excluded

5a109fc

rithviknishad requested a review from a team as a code owner February 17, 2025 10:15

rithviknishad added needs testing needs review P1 breaking issue or vital feature labels Feb 17, 2025

rithviknishad requested a review from Jacobjeevan February 17, 2025 10:15

coderabbitai bot reviewed Feb 17, 2025

View reviewed changes

nihal467 added tested and removed needs testing labels Feb 17, 2025

khavinshankar approved these changes Feb 17, 2025

View reviewed changes

khavinshankar merged commit 7f8dbc8 into develop Feb 17, 2025
18 of 24 checks passed

khavinshankar deleted the rithviknishad/fix/autocomplete-and-resource-form-facility-pre-fill branch February 17, 2025 12:26

Jacobjeevan removed the needs review label Feb 17, 2025

rithviknishad self-assigned this Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge autocomplete options; Fixes facility select in resource form edge case #10646

Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge autocomplete options; Fixes facility select in resource form edge case #10646

rithviknishad commented Feb 17, 2025 •

edited

Loading

coderabbitai bot commented Feb 17, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 17, 2025 •

edited

Loading

coderabbitai bot left a comment

cypress bot commented Feb 17, 2025

nihal467 commented Feb 17, 2025

khavinshankar commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge autocomplete options; Fixes facility select in resource form edge case #10646

Fix autocomplete unable to pre-fill in certain usages; Adds utility fn. to merge autocomplete options; Fixes facility select in resource form edge case #10646

Conversation

rithviknishad commented Feb 17, 2025 • edited Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 17, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 17, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

cypress bot commented Feb 17, 2025

CARE Run #4831

Tests for review

nihal467 commented Feb 17, 2025

khavinshankar commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

rithviknishad commented Feb 17, 2025 •

edited

Loading

coderabbitai bot commented Feb 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 17, 2025 •

edited

Loading