Improves responsiveness of Encounter Medicines tab #10511

Tanuj1718 · 2025-02-09T08:21:59Z

Proposed Changes

Fixes Mobile View UI: Medicines page in Encounter needs responsiveness #10412

Before Update:

After Update:

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Style
- Improved the component layout to enhance responsiveness.
- Adjusted the arrangement of the search area and controls for a smoother display on various screen sizes.
- Updated the TabsList layout for cleaner presentation.

…evelop

coderabbitai · 2025-02-09T08:22:08Z

Walkthrough

The changes update the layout of the MedicationRequestTable component. CSS classes for the TabsList and the inner container wrapping the search input and buttons have been modified to include flex-wrap. These updates enhance the responsiveness of the component for mobile views without affecting its underlying functionality.

Changes

File	Change Summary
src/components/Medicine/…/MedicationRequestTable/index.tsx	Updated CSS classes: removed unnecessary space in `TabsList` and added `flex-wrap` to the inner div to improve responsiveness.

Assessment against linked issues

Objective	Addressed	Explanation
Mobile View UI: Medicines page in Encounter responsiveness (#10412)	✅

Suggested labels

tested, needs review

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

In a field of code I hop with glee,
Fixing layouts for all to see.
Tabs now flow with graceful art,
Responsive magic—a mobile heart.
With a twitch of whiskers and a cheerful beat,
This bunny’s work makes the app complete!
Hop on and code, for all is neat!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d12bf1 and fbe0648.

📒 Files selected for processing (1)

src/components/Medicine/MedicationRequestTable/index.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Medicine/MedicationRequestTable/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-09T08:22:19Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`fbe0648`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67aa4f54b1d703000816b77f
😎 Deploy Preview	https://deploy-preview-10511--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Medicine/MedicationRequestTable/index.tsx (1)
134-134: LGTM! Consider a minor improvement for better wrapping.

The addition of flex-wrap allows proper stacking of elements on mobile screens. However, consider adding a min-width to the search container to ensure optimal wrapping behavior.
-              <div className="flex items-center justify-between p-2 gap-2 flex-wrap">
+              <div className="flex items-center justify-between p-2 gap-2 flex-wrap min-w-[200px]">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da958f1 and 6d12bf1.

📒 Files selected for processing (1)

src/components/Medicine/MedicationRequestTable/index.tsx (2 hunks)

🔇 Additional comments (1)

src/components/Medicine/MedicationRequestTable/index.tsx (1)

117-117: LGTM! Good responsive design implementation.

The addition of h-fit flex flex-wrap classes to the TabsList enables proper wrapping of tabs on smaller screens while maintaining a flexible height, improving mobile responsiveness.

src/components/Medicine/MedicationRequestTable/index.tsx

…x-ui

github-actions · 2025-02-11T17:22:20Z

@Tanuj1718 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Tanuj1718 and others added 16 commits February 4, 2025 00:21

improved tablet view responsiveness

ea4a69b

solved i18n issue

85bfad8

Merge branch 'develop' into develop

09f613a

update mobile view responsiveness

158d709

Merge branch 'develop' into develop

b39654d

added responsiveness in organization users page

c4586e6

Merge branch 'develop' into develop

ea48433

minor change in button

73c1773

Merge branch 'develop' of https://github.com/Tanuj1718/care_fe into d…

5283828

…evelop

draft pr

ffdb6df

modified date-field handlers

f46c2eb

minor cleanup

4dfd361

Merge branch 'develop' into fix-issue

70eca3e

Merge branch 'develop' into fix-issue

6f00675

revert unwanted changes

e1b3c37

fix responsiveness

a32aeef

Tanuj1718 requested a review from a team as a code owner February 9, 2025 08:22

Merge branch 'develop' into fix-ui

6d12bf1

coderabbitai bot reviewed Feb 9, 2025

View reviewed changes

Jacobjeevan requested changes Feb 10, 2025

View reviewed changes

src/components/Medicine/MedicationRequestTable/index.tsx Outdated Show resolved Hide resolved

Tanuj1718 added 3 commits February 11, 2025 00:35

minor change

ebdc962

Merge remote-tracking branch 'upstream/develop' into fix-ui

ad685aa

Merge branch 'fix-ui' of https://github.com/Tanuj1718/care_fe into fi…

fbe0648

…x-ui

Tanuj1718 requested a review from Jacobjeevan February 10, 2025 19:43

Jacobjeevan added the tested label Feb 11, 2025

Jacobjeevan approved these changes Feb 11, 2025

View reviewed changes

Jacobjeevan merged commit 29060ed into ohcnetwork:develop Feb 11, 2025
14 of 15 checks passed

coderabbitai bot mentioned this pull request Feb 12, 2025

fix: Organization Users page needs responsiveness #10413

Merged

6 tasks

coderabbitai bot mentioned this pull request Feb 21, 2025

fix: Add responsiveness in Encounter Medicines tab #10742

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improves responsiveness of Encounter Medicines tab #10511

Improves responsiveness of Encounter Medicines tab #10511

Tanuj1718 commented Feb 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 9, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 9, 2025 •

edited

Loading

coderabbitai bot left a comment

github-actions bot commented Feb 11, 2025

Improves responsiveness of Encounter Medicines tab #10511

Improves responsiveness of Encounter Medicines tab #10511

Conversation

Tanuj1718 commented Feb 9, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 9, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 9, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 11, 2025

Tanuj1718 commented Feb 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 9, 2025 •

edited

Loading