Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default EOL to "LF" in prettier.json #10084

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Jan 21, 2025

Proposed Changes

  • Fixes #issue_number
  • Change 1
  • Change 2
  • More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Documentation

    • Updated Cypress testing documentation with new sections on overview, quick links, core principles, getting started, and support
    • Refined documentation in Utils/request README with improved formatting and syntax
  • Chores

    • Updated GitHub Actions workflows for deployment and linting
    • Adjusted Prettier configuration to specify line endings
    • Minor formatting updates to various configuration files
  • Style

    • Updated icon path definitions in CAREUI icon collections

@nihal467 nihal467 requested a review from a team as a code owner January 21, 2025 09:26
Copy link
Contributor

coderabbitai bot commented Jan 21, 2025

Walkthrough

This pull request encompasses a series of minor configuration and documentation updates across various files in the project. The changes include workflow modifications in GitHub Actions, updates to Prettier and VS Code configurations, Cypress documentation expansion, icon path reformatting, and documentation improvements. Most changes are focused on formatting, readability, and minor structural adjustments without significantly altering core functionality.

Changes

File Change Summary
.github/workflows/deploy.yaml Added notify-release job, updated build job conditions
.github/workflows/linter.yml Minor formatting change in Node.js version specification
.github/workflows/release.yml Removed extra space in comment
.prettierrc.json Added endOfLine: "lf", reformatted importOrder and plugins
.vscode/launch.json Reformatted indentation
crowdin.yml Added newline at end of file
cypress/docs/cypress.md Added new documentation sections: Overview, Quick Links, Core Principles, Getting Started, Support
src/CAREUI/icons/DuoTonePaths.json Reformatted icon path definitions
src/CAREUI/icons/UniconPaths.json Condensed multiline entries to single lines
src/Utils/request/README.md Updated documentation formatting and syntax

Possibly related PRs

Suggested labels

needs review, good to merge

Suggested reviewers

  • rithviknishad

Poem

🐰 A Rabbit's Workflow Rhyme 🚀

In GitHub's garden, configs bloom,
Workflows dance, dispelling gloom,
Prettier lines and icons bright,
Documentation shining light,
A code ballet of pure delight! 🌈


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46faa4b and 566747a.

📒 Files selected for processing (10)
  • .github/workflows/deploy.yaml (0 hunks)
  • .github/workflows/linter.yml (1 hunks)
  • .github/workflows/release.yml (1 hunks)
  • .prettierrc.json (1 hunks)
  • .vscode/launch.json (1 hunks)
  • crowdin.yml (1 hunks)
  • cypress/docs/cypress.md (1 hunks)
  • src/CAREUI/icons/DuoTonePaths.json (1 hunks)
  • src/CAREUI/icons/UniconPaths.json (3 hunks)
  • src/Utils/request/README.md (13 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/deploy.yaml
✅ Files skipped from review due to trivial changes (9)
  • crowdin.yml
  • .github/workflows/linter.yml
  • src/CAREUI/icons/UniconPaths.json
  • .github/workflows/release.yml
  • .prettierrc.json
  • .vscode/launch.json
  • cypress/docs/cypress.md
  • src/CAREUI/icons/DuoTonePaths.json
  • src/Utils/request/README.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cloudflare Pages: care-fe

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 566747a
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/678f682b6410af0008c98af8
😎 Deploy Preview https://deploy-preview-10084--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member Author

nihal467 commented Jan 21, 2025

@rithviknishad is it ok, to default to LF, let me know ?

Copy link

cypress bot commented Jan 21, 2025

CARE    Run #4364

Run Properties:  status check passed Passed #4364  •  git commit 566747aead: Default EOL to "LF" in prettier.json
Project CARE
Branch Review change-endofline
Run status status check passed Passed #4364
Run duration 02m 52s
Commit git commit 566747aead: Default EOL to "LF" in prettier.json
Committer Mohammed Nihal
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

@rithviknishad rithviknishad merged commit 640fedd into develop Jan 21, 2025
29 checks passed
@rithviknishad rithviknishad deleted the change-endofline branch January 21, 2025 10:10
Copy link

@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants