-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/google maps link #10003
Closed
rahulharpal1603
wants to merge
20
commits into
ohcnetwork:develop
from
rahulharpal1603:feat/Google-Maps-Link
+72
−2
Closed
Feat/google maps link #10003
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
042702c
Add Google Maps link for facility location and update facility data type
rahulharpal1603 fa95cbc
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 1c1731e
Remove Google Maps entries from localization files and clean up conso…
rahulharpal1603 8131ced
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 8e375be
Fix: change latitude and longitude types from string to number in Fac…
rahulharpal1603 dfd83e9
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 c0109a7
Added conditional link handling based on whether device is Android or…
rahulharpal1603 5671e1e
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 c93b037
Create separate component for Facility Maps link and add it to both a…
rahulharpal1603 88e05ae
add props validation for coordinates.
rahulharpal1603 4c019c1
Fix TS errors
rahulharpal1603 dca61e3
improve props validation
rahulharpal1603 3378e84
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 15d9f07
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 a8a1032
fixed non-existent coordinates problem
rahulharpal1603 0344faf
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
rahulharpal1603 4b72654
using Number.isNaN
rahulharpal1603 90d859c
Merge branch 'develop' into feat/Google-Maps-Link
rahulharpal1603 81f6b71
Remove unnecessary blank line in FacilityHome component
rahulharpal1603 95eef75
Merge branch 'develop' into feat/Google-Maps-Link
rahulharpal1603 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
improve props validation
commit dca61e3623b6f95ed38a8f1f52307e17a2961c66
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance coordinate validation.
The current validation approach using
console.error
in a hook has several limitations:Consider this alternative approach: